Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint spacing errors #15891

Closed
wants to merge 1 commit into from
Closed

Fix lint spacing errors #15891

wants to merge 1 commit into from

Conversation

dcalhoun
Copy link
Member

These styling violations likely occurred during the relocation of
Fastlane files to the top-level directory. #15884

To test: rake lint

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

These styling violations likely occurred during the relocation of
Fastlane files to the top-level directory. #15884
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@dcalhoun dcalhoun added this to the 16.8 milestone Feb 15, 2021
@dcalhoun dcalhoun added the Tooling Build, Release, and Validation Tools label Feb 15, 2021
@dcalhoun dcalhoun requested a review from jkmassel February 15, 2021 19:51
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun
Copy link
Member Author

@jkmassel would you please verify that these changes are needed. After attempting to merge the latest develop into #15665, my git merge --continue failed with linter errors related to spacing. These changes address those errors via rake lint:autocorrect.

@dcalhoun dcalhoun added Tooling Build, Release, and Validation Tools and removed Tooling Build, Release, and Validation Tools labels Feb 16, 2021
@jkmassel
Copy link
Contributor

Thanks for taking a look at this @dcalhoun!

It looks like our emergency bundler fix also had this change in it, so I'll close this one.

Thanks again!!

@jkmassel jkmassel closed this Feb 16, 2021
@jkmassel jkmassel deleted the fix-lint-spacing-errors branch February 16, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Code Review Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants