-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gravatar related deprecated types and replace with Gravatar SDK #23429
Conversation
This reverts commit 81adf3d.
Generated by 🚫 Danger |
@@ -36,7 +37,9 @@ class LoginLinkRequestViewController: LoginViewController { | |||
|
|||
let email = loginFields.username | |||
if email.isValidEmail() { | |||
gravatarView?.downloadGravatarWithEmail(email, rating: .x) | |||
Task { | |||
try await gravatarView?.setGravatarImage(with: email, placeholder: .gravatarPlaceholderImage, rating: .x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to make this code run even though I followed the email link flow. Maybe I am missing something.
But this is the same method we call from GravatarEmailTableViewCell.swift
. And I was able to test that.
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23429-892f1ba | |
Version | 25.1 | |
Bundle ID | com.jetpack.alpha | |
Commit | 892f1ba | |
App Center Build | jetpack-installable-builds #9358 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23429-892f1ba | |
Version | 25.1 | |
Bundle ID | org.wordpress.alpha | |
Commit | 892f1ba | |
App Center Build | WPiOS - One-Offs #10313 |
About the dangermattic warning. I ran |
Please disregard this warning as its a false positive. The dependencies are pinned in AppCenter is down. I'll test it once it back up again. Thank you for the PR! 🙇 |
Thanks, will look into it! It is indeed a false positive. |
Tested – all looks good |
Fixes #
We deprecated some Gravatar related types and methods when integrating the Gravatar SDK with PR: #22921. Now it is time to remove those deprecated types.
This PR also replaces a piece of code in WordPressAuthenticator that was still using the deprecated methods.
To test:
The avatar should look OK in the password entry page:
Regression Notes
Avatars in login flow.
I tested the login flow.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: