-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move +classNameWithoutNamespaces
to WordPressSharedObjC
#24164
Merged
Merged
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24164-57a9e60 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 57a9e60 | |
App Center Build | WPiOS - One-Offs #11609 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24164-57a9e60 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 57a9e60 | |
App Center Build | jetpack-installable-builds #10640 |
Hey Gio, did you mean to base it off |
kean
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve it to make it mergable once the commit history is updated.
So we can use it next in WordPressData.
81890b9
to
57a9e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to move the Core Data model to WordPressData but got bogged with an
NSArray element failed to match the Swift Array Element type
exception — More details in #24166.Given that work is still in progress, I thought we could at least merge this pre-condition change to move (actually duplicate for migration convenience) the
classNameWithoutNamespaces
method onNSObject
that the models use to create theirNSFetchRequest
.WordPress-iOS/WordPress/Classes/Models/BloggingPrompt+CoreDataClass.swift
Lines 5 to 9 in 85215d2