Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ts-mocha #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump ts-mocha #2

wants to merge 1 commit into from

Conversation

nathanleclaire
Copy link
Contributor

Seems anchor test wants this

@bluskript if it doesn't step on your stuff probably want to merge to enable anchor test to work properly

@nathanleclaire nathanleclaire mentioned this pull request Jul 13, 2022
Closed
@bluskript
Copy link
Collaborator

wait... there's now both a pnpm and a yarn lockfile. could we stick with pnpm for this repo?

sammanadh
sammanadh approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@sammanadh sammanadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. Thanks.

@nathanleclaire
Copy link
Contributor Author

wait... there's now both a pnpm and a yarn lockfile. could we stick with pnpm for this repo?

I don't have a preference either way, could you document instructions for pnpm in README and rm yarn.lock if it's not used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammanadh sammanadh sammanadh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanleclaire @bluskript @sammanadh