feat: Add DuchyId into FailComputationParticipant message.

[renjiezh]

No description provided.

[wfa-reviewable]

This change is 

[SanjayVas]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/FailComputationParticipant.kt line 130 at r1 (raw file):

        failure = measurementFailure {
          reason = MeasurementFailure.Reason.COMPUTATION_PARTICIPANT_FAILED
          message = "Computation Participant failed. $duchyId: ${request.logMessage}"

I already rejected this change in a previous PR.

The gRPC status message may have IDs, but not this log message field. Anyone reading this log message field has access to the Duchy log entry protobuf message which has the Duchy ID.

Code quote:

$duchyId:

[SanjayVas]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/FailComputationParticipant.kt line 130 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

I already rejected this change in a previous PR.

The gRPC status message may have IDs, but not this log message field. Anyone reading this log message field has access to the Duchy log entry protobuf message which has the Duchy ID.

See reasoning from #1835

[SanjayVas]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/FailComputationParticipant.kt line 130 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

See reasoning from #1835

Sorry, I guess they don't have access to that from this one. I thought I was looking at the log entry itself.

The correct thing to do here is to add another field in the protobuf message that indicates the external Duchy ID. That can be plumbed through to the public API. Again, see my comments on #1835