-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use poetry for dependency management given lambda deployment #39
Conversation
Updated tests, but just wanted to flag that running CI workflow locally with Command: Result:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I think it's fine for now but I might propose a larger refactor of the directory arch later
What I Changed
pyproject.toml
to poetry syntaxpoetry.lock
fileHow to Test it
poetry install
)cdk deploy
--> live hereOther Notes
I tried implementing groups to keep
mangum
outside of the core dependencies, but I wasn't able to get the CDK deployment to pick up on the group dependencies under[tool.poetry.group.lambda.dependencies]
. I also tried this approach in thepyproject.toml
with the same result:I'm unsure if we should keep
mangum
in the core dependencies and keep the simplicity of the current CDK deployment or refactor something in the deployment.