Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Return correct account count in hubble_getNetworkInfo result #594

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

max-sidorov
Copy link
Contributor

No description provided.

@max-sidorov max-sidorov marked this pull request as ready for review February 21, 2022 13:41
@max-sidorov max-sidorov requested a review from msieczko February 21, 2022 13:42
Copy link

@msieczko msieczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache the number of accounts in Storage and update it on Set operations

@max-sidorov max-sidorov marked this pull request as draft February 21, 2022 17:08
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #594 (15d4f73) into master (78492d0) will increase coverage by 0.01%.
The diff coverage is 73.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   61.82%   61.84%   +0.01%     
==========================================
  Files         281      281              
  Lines       13238    13281      +43     
==========================================
+ Hits         8185     8213      +28     
- Misses       4235     4247      +12     
- Partials      818      821       +3     
Flag Coverage Δ
build-test 61.84% <73.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/storage.go 79.38% <40.00%> (-2.34%) ⬇️
storage/state_tree.go 62.73% <76.27%> (+0.81%) ⬆️
api/get_network_info.go 71.42% <100.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78492d0...15d4f73. Read the comment docs.

@max-sidorov max-sidorov marked this pull request as ready for review February 22, 2022 12:00
@max-sidorov max-sidorov requested a review from msieczko February 22, 2022 12:00
storage/state_tree_test.go Show resolved Hide resolved
@msieczko msieczko changed the title Account count in getNetworkInfo result returns a wrong value if other commander adds new state leaves in random order Return correct account count in hubble_getNetworkInfo result Mar 1, 2022
@max-sidorov max-sidorov requested a review from msieczko March 2, 2022 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants