Add identity deletion client tests #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POP-1859 Add end-to-end tests for identity deletion in MPCv2 [in Rust]
Add e2e tests in iris-mpc Rust codebase so that any new changes can be validated to work on identity-deletion side. |
eaypek-tfh
force-pushed
the
POP-1859/add-client-tests-for-identity-deletion
branch
2 times, most recently
from
f649bf6
to
d48da32
Compare
philsippl
reviewed
Sep 18, 2024
iris-mpc/src/bin/client.rs
Outdated
| @@ -354,7 +420,7 @@ async fn main() -> eyre::Result<()> { | |||
| }; | |||
|
|
|||
| let request_message = UniquenessRequest { | |||
| batch_size: None, | |||
| batch_size: Some(1), | |||
There was a problem hiding this comment.
Should we rather set this to BATCH_SIZE?
philsippl
approved these changes
Sep 18, 2024
eaypek-tfh
force-pushed
the
POP-1859/add-client-tests-for-identity-deletion
branch
from
424c587
to
ae9c283
Compare
eaypek-tfh
force-pushed
the
POP-1859/add-client-tests-for-identity-deletion
branch
from
93d6f9e
to
9d0ddf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change