feat: added clippy to CI #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKitsune
approved these changes
Jul 8, 2024
teor2345
suggested changes
Jul 8, 2024
There was a problem hiding this comment.
Thank you for adding this!
It might be better to put this in its own workflow, so we can turn it off independently. What do you think?
Each workflow can be disabled here, but individual jobs or steps can’t:
https://github.com/worldcoin/gpu-iris-mpc/actions
If we don’t make that change, let’s create a separate job, so we have separate format and clippy status indicators?
teor2345
suggested changes
Jul 8, 2024
src/bin/server.rs
Outdated
| @@ -993,10 +986,12 @@ async fn main() -> eyre::Result<()> { | |||
| // before running that code. | |||
| // - End events are re-used in each thread, but we only end one thread at a | |||
| // time. | |||
| assert!(MAX_BATCHES_BEFORE_REUSE > MAX_CONCURRENT_BATCHES); | |||
| // (Dragos) Commented assert here since it's going to be optimized by the | |||
| // compiler assert!(MAX_BATCHES_BEFORE_REUSE > MAX_CONCURRENT_BATCHES); | |||
There was a problem hiding this comment.
This assertion is required for memory safety reasons.
To make sure it is checked at compile time, and silence the warning, replace it with static_assertions::const_assert!():
https://docs.rs/static_assertions/latest/static_assertions/macro.const_assert.html
teor2345
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding clippy check to CI