Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add versions #33

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: add versions #33

merged 1 commit into from
May 28, 2024

Conversation

igorosip0v
Copy link
Contributor

Adds versions to the commands

@igorosip0v igorosip0v self-assigned this May 28, 2024
@linear Linear
Copy link

linear bot commented May 28, 2024

WID-1006 Minikit Versioning 

{
    "command": "some_minikit_command",
    "version": 1,
    "payload": { ... }
}

Include versioning inside of each payload sent to the app. Please update the spec accordingly. The reason we are adding versioning is so that we can have custom handling for various versions of the app.

@vercel Vercel
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
minikit-js-with-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:43am

@igorosip0v igorosip0v changed the base branch from main to dev May 28, 2024 10:19
@igorosip0v igorosip0v merged commit eab4ade into dev May 28, 2024
4 checks passed
@igorosip0v igorosip0v deleted the igorosipov-wid-1006-minikit-versioning branch May 28, 2024 10:29
andy-t-wang pushed a commit that referenced this pull request May 28, 2024
@igorosip0v
Sync main with dev (#36)
72aa8ef 
* trigger deploy

* feat: add versions (#33)

* update app payloads (#35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-t-wang andy-t-wang andy-t-wang approved these changes

Assignees

@igorosip0v igorosip0v

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorosip0v @andy-t-wang