-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orb-ui: diamond: self-serve with cone support #172
Draft
fouge
wants to merge
3
commits into
main
Choose a base branch
from
fouge/orb-ui-diamond-self-serve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial cone support
fouge
force-pushed
the
fouge/orb-ui-diamond-self-serve
branch
from
July 31, 2024 10:18
706530b
to
b58e06c
Compare
fouge
force-pushed
the
fouge/orb-ui-cone
branch
from
August 7, 2024 10:01
58d3d45
to
ae6aa9d
Compare
Qbicz
reviewed
Aug 26, 2024
std::thread::sleep(std::time::Duration::from_secs( | ||
CONE_LED_STRIP_RAINBOW_PERIOD_S, | ||
)); | ||
counter = (counter + 1) % 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about naming this magic 6
? It will be easier to understand it's purpose ;)
fouge
force-pushed
the
fouge/orb-ui-cone
branch
3 times, most recently
from
September 3, 2024 16:27
9f3fe3c
to
7d90c4f
Compare
@fouge shall we rebase on main and mark as ready for review? |
@TheButlah i'm gonna have a look today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UX with cone in Diamond self-serve mode.
fixes ORBP-113