orb-mcu-util: control gimbal #268
Open
+97
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
approved these changes
Oct 18, 2024
mcu-util/src/orb/mod.rs
Outdated
| @@ -84,6 +84,10 @@ impl Orb { | |||
| } | |||
| } | |||
|
|
|||
| pub fn borrow_mut_main_board(&mut self) -> &mut MainBoard { | |||
There was a problem hiding this comment.
could call it main_board_mut(&mut self) and main_board(&self)? This is the convention in rust.
allows to trigger auto-home and set gimbal position for testing.
fouge
force-pushed
the
fouge/mcu-util-gimbal-control
branch
from
4b5e33d
to
5ce0141
Compare
rust convention
fouge
force-pushed
the
fouge/mcu-util-gimbal-control
branch
from
5ce0141
to
f9108c5
Compare
TheButlah
approved these changes
Oct 21, 2024
TheButlah
approved these changes
Oct 23, 2024
fouge
force-pushed
the
fouge/mcu-util-gimbal-control
branch
from
3c4e4d7
to
cd18b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows to trigger auto-home and set gimbal position for testing.
fixes O-2915