Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics. #67

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Add more metrics. #67

merged 2 commits into from
Oct 24, 2024

Conversation

piohei
Copy link
Contributor

@piohei piohei commented Oct 22, 2024

No description provided.

@cichaczem cichaczem requested a review from jazzbee October 22, 2024 10:59
@cichaczem
Copy link
Contributor

Adding @jazzbee just in case he has an input

Dzejkop
Dzejkop approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Dzejkop Dzejkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piohei
Copy link
Contributor Author

piohei commented Oct 23, 2024

I've used serve mux from datadog library which I think should allow to use just different configuration to support tracing. https://docs.datadoghq.com/tracing/trace_collection/trace_context_propagation/?tab=go

@piohei piohei merged commit 018e2d1 into master Oct 24, 2024
6 checks passed
@piohei piohei deleted the piohei/add_metrics branch October 24, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cichaczem cichaczem cichaczem approved these changes

@Dzejkop Dzejkop Dzejkop approved these changes

@jazzbee jazzbee Awaiting requested review from jazzbee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piohei @cichaczem @Dzejkop