introduce PackedProofs to semaphore-rs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoolsey
approved these changes
Sep 16, 2024
Dzejkop
reviewed
Sep 16, 2024
|
|
||
| let packed_proof = PackedProof::from(proof); | ||
|
|
||
| assert_eq!(packed_proof.to_string(), "0x00000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000005000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000008"); |
There was a problem hiding this comment.
Can you add a test that parses from string (with or without 0x)?
And another that serializes/deserializes to json?
Dzejkop
approved these changes
Sep 16, 2024
0xKitsune
approved these changes
Sep 16, 2024
pdtfh
added a commit
that referenced
this pull request
Sep 16, 2024
pdtfh
added a commit
that referenced
this pull request
Sep 16, 2024
Dzejkop
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packed proofs are a more developer-friendly way of passing ZKPs. This introduces support for packed proofs as used by World App, Developer Portal, helper contracts.