upgrade wormhole-relayer mainnet scripts #3492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature release mitigates CVE-2023-39325
This is required for building the guardiand binary
- Context is generally a worthless import - Ownable is totally unused and a worthless import
To follow standard forge testing practice, you use the same filename for a test contract as for the file it is testing, but make the extension .t.sol.
By moving the structs out of the abstract contract, you can use them directly in any contract that imports QueryResponse.sol *without* requiring that contract to inherit from the QueryResponse contract. This seems to work much better with forge's coverage tooling.
Instead of the test contract inheriting directly from the QueryResponse contract, it instantiates an instance of it and uses that for the testing. This seems to work much nicer with the forge coverage tools. With this commit, the coverage for QueryResponse shows 85.1% line coverage, 100% function coverage, and 50% branch coverage.
If you don't do this, in the tests you have to do:
vm.expectRevert(bytes4(keccak256("UnsupportedQueryType()")));
Whereas with this change, you can simply import the contract and do:
vm.expectRevert(UnsupportedQueryType.selector);
* Gas bad * Natspec updates * Some address(0) checks in the constructor
* Use custom errors in place of require() to match the error handling style overall of QueryResponse.
* Node/EVM: More nodes support finalized and safe * Remove unused finalizers
Now that the google cloud logging support is removed, this is from:
go mod tidy -v
The output was:
unused cloud.google.com/go
unused cloud.google.com/go/logging
unused cloud.google.com/go/longrunning
unused github.com/googleapis/gax-go/v2
* CCQ: eth_call_with_finality * Attempt to fix tilt error
* base is domain 6 * explicit CCTP domain to name mapping
scnale
force-pushed
the
evm/upgrade-automatic-relayers-mainnet-wip
branch
from
43ef5d9 to
5a9361f
Compare
|
Closing as @solanoepalacio mentioned this was superseded by #3522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.