Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node/CCQ: Solana query support #3637

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Node/CCQ: Solana query support #3637

merged 10 commits into from
Jan 23, 2024

Conversation

bruce-riley
Copy link
Contributor

No description provided.

@bruce-riley bruce-riley force-pushed the node/ccq_solana_query_support branch 5 times, most recently from 4c3cf41 to aecc11c Compare January 10, 2024 16:28
evan-gray
evan-gray requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the whitepaper for starters

@bruce-riley bruce-riley force-pushed the node/ccq_solana_query_support branch 9 times, most recently from fe3fa8e to 3f3d472 Compare January 12, 2024 18:57
evan-gray
evan-gray reviewed Jan 12, 2024
View reviewed changes
@bruce-riley bruce-riley force-pushed the node/ccq_solana_query_support branch from 3f3d472 to 769cfa8 Compare January 12, 2024 22:32
@bruce-riley bruce-riley marked this pull request as ready for review January 16, 2024 19:21
panoel
panoel reviewed Jan 16, 2024
View reviewed changes
panoel
panoel previously approved these changes Jan 16, 2024
View reviewed changes
@bruce-riley bruce-riley requested a review from evan-gray January 17, 2024 14:33
@SEJeff SEJeff requested a review from mdulin2 January 18, 2024 16:24
@bruce-riley bruce-riley requested a review from evan-gray January 18, 2024 17:50
evan-gray
evan-gray previously approved these changes Jan 18, 2024
View reviewed changes
evan-gray
evan-gray previously approved these changes Jan 18, 2024
View reviewed changes
djb15
djb15 previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, but logically it looks good to me

@bruce-riley bruce-riley dismissed stale reviews from djb15 and evan-gray via 80c577e January 19, 2024 16:01
felix-asym
felix-asym previously approved these changes Jan 19, 2024
View reviewed changes
@evan-gray evan-gray requested a review from felix-asym January 19, 2024 18:37
djb15
djb15 approved these changes Jan 19, 2024
View reviewed changes
SEJeff
SEJeff approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits worth changing in a followup, but nothing major!

@bruce-riley bruce-riley merged commit 59dff67 into main Jan 23, 2024
22 checks passed
@bruce-riley bruce-riley deleted the node/ccq_solana_query_support branch January 23, 2024 00:59
@bruce-riley bruce-riley mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SEJeff SEJeff SEJeff approved these changes

@djb15 djb15 djb15 approved these changes

@evan-gray evan-gray evan-gray approved these changes

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters kev1n-peters is a code owner

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2

@felix-asym felix-asym Awaiting requested review from felix-asym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bruce-riley @SEJeff @djb15 @panoel @evan-gray @felix-asym