CCQ/EVM: Testing library for building responses #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
ccq/evm_testing_library_for_building_responses
branch
6 times, most recently
from
8eed896 to
8894390
Compare
jaydenwindle
reviewed
Feb 9, 2024
bruce-riley
force-pushed
the
ccq/evm_testing_library_for_building_responses
branch
from
a1ab016 to
f0ca59f
Compare
bruce-riley
requested review from
a5-pickle,
gator-boi and
kcsongor
as code owners
bruce-riley
requested review from
djb15
and removed request for
jaydenwindle
djb15
reviewed
Feb 21, 2024
There was a problem hiding this comment.
What do you think about all the buildXXXBytes methods also returning the length of the bytes being returned?
There are a lot of lengths passed around that presumably a user has to manually fetch themselves with BYTES.length.
If we did this you can disregard my inline comment
|
@djb15, I changed the functions to derive the length from the bytes passed in, which I think eliminates the need to make the functions also return the length? Please let me know if you disagree. |
bruce-riley
force-pushed
the
ccq/evm_testing_library_for_building_responses
branch
from
ee0b650 to
feae3f5
Compare
djb15
approved these changes
Feb 27, 2024
gator-boi
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.