Upgrade sui packages and compiler to 1.19.1-mainnet #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcsongor
commented
Mar 1, 2024
kcsongor
force-pushed
the
sui-upgrade
branch
7 times, most recently
from
9181d0b to
497fb6c
Compare
|
my understanding is that this is failing in CI because the Sui deployment / devnet is no longer deterministic, perhaps due to the removal of the |
evan-gray
force-pushed
the
sui-upgrade
branch
2 times, most recently
from
53a2b70 to
6d64317
Compare
evan-gray
requested review from
evan-gray,
kev1n-peters,
barnjamin,
bruce-riley,
SEJeff and
a5-pickle
as code owners
evan-gray
approved these changes
Apr 12, 2024
bruce-riley
approved these changes
Apr 15, 2024
a5-pickle
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not require a contract upgrade, as the packages are backwards compatible, but it allows integrators to more seamlessly build on wormhole, as the previous dependencies were fairly out of date.
The ts tests fail for some obscure reason, haven't investigated why.