Exit early with error if no roles are specified during user add-role

wp-cli · Nov 10, 2023 · 19b1005 · 19b1005
1 parent 480e4cf
commit 19b1005
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/features/user.feature b/features/user.feature
@@ -209,6 +209,14 @@ Feature: Manage WordPress users
   Scenario: Managing user roles
     Given a WP install
 
+    When I run `wp user add-role 1`
+    Then the return code should be 1
+    And STDERR should be:
+      """
+      Error: Please specify at least one role to add.
+      """
+    And STDOUT should be empty
+
     When I run `wp user add-role 1 editor`
     Then STDOUT should not be empty
     And I run `wp user get 1 --field=roles`

diff --git a/src/User_Command.php b/src/User_Command.php
@@ -712,6 +712,10 @@ public function add_role( $args, $assoc_args ) {
 		$roles = $args;
 		array_shift( $roles );
 
+		if ( empty( $roles ) ) {
+			WP_CLI::error( 'Please specify at least one role to add.' );
+		}
+
 		foreach ( $roles as $role ) {
 			self::validate_role( $role );
 		}