Fix warning message in user spam command (#481)

wp-cli · Mar 1, 2024 · cdaca28 · cdaca28
1 parent 6f7fa72
commit cdaca28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/features/user.feature b/features/user.feature
@@ -586,7 +586,6 @@ Feature: Manage WordPress users
     And STDERR should be:
       """
       Warning: Invalid user ID, email or login: '9999'
-      Warning: User 9999 doesn't exist.
       Error: Only spammed 1 of 2 users.
       """
     And the return code should be 1

diff --git a/src/User_Command.php b/src/User_Command.php
@@ -1339,15 +1339,8 @@ private function update_msuser_status( $user_ids, $pref, $value ) {
 			$errors = count( $user_ids ) - count( $users );
 		}
 
-		foreach ( $user_ids as $user_id ) {
-
-			$user = get_userdata( $user_id );
-
-			// If no user found, then show warning.
-			if ( empty( $user ) ) {
-				WP_CLI::warning( "User {$user_id} doesn't exist." );
-				continue;
-			}
+		foreach ( $users as $user ) {
+			$user_id = $user->ID;
 
 			// Super admin should not be marked as spam.
 			if ( is_super_admin( $user->ID ) ) {