Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPCS default rule set #161

Merged
merged 10 commits into from
Jul 29, 2018
Merged

Update PHPCS default rule set #161

merged 10 commits into from
Jul 29, 2018

Commits on Jul 20, 2018

  1. change to .phpcs.xml.dist and update rules 

    The .phpcs.xml.dist rule file is detected and implemented automatically, reducing complexity for running phpcs.

The updated rules account for new wpcs sniff properties including the ability to check global prefix and i18n implementation with the correct text domain when specified.

The values have been left blank so the sniffs are generic, but the rules are in place to make it easier to get started by scaffold.
    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    1e581ba View commit details
    Browse the repository at this point in the history

  2. add comments for blank values

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    e4a3d1b View commit details
    Browse the repository at this point in the history

  3. updates per pr feedback

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    b64faae View commit details
    Browse the repository at this point in the history

  4. update based on more PR feedback 

    change the the ruleset name and add a comment explaining parellel processing.
    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    d1047f2 View commit details
    Browse the repository at this point in the history

  5. add placeholder for prefix and textdomain rules

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    c449067 View commit details
    Browse the repository at this point in the history

  6. add comments and update rule ref 

    also converts spaces to tabs
    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    4160c12 View commit details
    Browse the repository at this point in the history

  7. remove leading .

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    d0ac996 View commit details
    Browse the repository at this point in the history

  8. update tests and distignore for .phpcs.xml.dist

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    2f23c5c View commit details
    Browse the repository at this point in the history

  9. update to handle additional phpcs rule files

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    c22db9a View commit details
    Browse the repository at this point in the history

  10. update test for verifying the ruleset contents

    Nick Croft committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    64920e5 View commit details
    Browse the repository at this point in the history