Replacement callback & row-based filtering #128
Conversation
Fix Travis CI caching for composer
Clarify this command as a bundled command
Use `--format=count` to only show number of rows affected
Suppress error in search-replace-export.feature.
Update package with latest scaffolded components
Use `dist: precise` for PHP 5.3, `dist: trusty` for everything else
Backtick code references so they're properly formatted on the website
Clarify "please flush object cache" message in multisite to mention cached lookup value
Add esc_sql_ident(), catering for reserved word column names.
Suppress error on fopen export file, revert PR wp-cli#16.
drzraf
changed the title
|
@drzraf Is this still a work-in-progress ? If not, can you do the necessary style changes to make PHPCS happy? Running See here: https://travis-ci.org/wp-cli/search-replace-command/jobs/586606309#L591-L709 |
|
Just did^ |
|
Could you please have a look. It was a huge MR update and I'll hardly find the motivation to further rework/update it again if merge-conflicts arised. It's also rare to have an opportunity window to test changes. |
|
ping |
|
@drzraf The code looks good so far, and I'd love to merge this. However, for merging it, we'll need tests as well that cover all the main code paths. Are you able to add such tests? |
|
Note: the Travis issues should be resolved by now. |
|
Hi @schlessera , I completely understand your concern given the shape of the diff. |
|
Thanks for the quick response! I'll see if I can manage to add the tests myself to get this included. |
|
Would you merge if I were to rebase it once again? |
|
Has this seen any update at all lately? I need to find a solution to search-replace by excluding revisions. 🤔 |
|
@davidwebca Want to open a new pull request with this code and tests covering the change? |
|
I'll a see what I can do! |
|
@danielbachhuber : What about providing writing tests since upstream are the ones who know how to best write them? I'd later see and possibly spend the necessary hours for another rebase. |
|
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/39778759a59cb231c94520e38ae3f6ba in case this PR is auto-closed or broken in some way. |
danielbachhuber
force-pushed
the
master
branch
from
288c656
to
fa755eb
Compare
|
@danielbachhuber Completely had forgotten about this. Do you have any guides or examples of tests (following up that conversation higher here?) |
|
@davidwebca Here's our guide to writing tests: https://make.wordpress.org/cli/handbook/contributions/pull-requests/#running-and-writing-tests There are plenty of examples within this and other repos. Feel free to stop by Also, specific to this pull request: I think a filter-based approach would work best for this need. |
Added --revision / --no-revision Added --callback Reroll wp-cli#104, wp-cli#128 Fixes wp-cli#125, wp-cli#127, wp-cli#142
$coland$primary_keysdown to the SearchReplacer #127 (Callback access to current primary key & column)--whereflag)