Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for WordPress trunk #197

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix test for WordPress trunk #197

merged 2 commits into from
Jun 28, 2024

Conversation

swissspidy
Copy link
Member

siteurl is not necessarily the first row in wp_options.

It appears that other options such as cron can be first.

This removes the option ID from the assertion, as it is not relevant.

We only want to verify that the site URL changed.

`siteurl` is not necessarily the first row in `wp_options`.

It appears that other options such as `cron` can be first.

This removes the option ID from the assertion, as it is not relevant.

We only want to verify that the site URL changed.
@swissspidy swissspidy added this to the 2.1.6 milestone Jun 28, 2024
@swissspidy swissspidy requested a review from a team as a code owner June 28, 2024 08:34
@ernilambar
Copy link
Member

siteurl is not necessarily the first row in wp_options.

It appears that other options such as cron can be first.

Any idea which recent core changeset made changes regarding this?

@swissspidy
Copy link
Member Author

Not really. Maybe one of the autoload-related changes 🤷

@swissspidy swissspidy merged commit 89e1653 into main Jun 28, 2024
38 checks passed
@swissspidy swissspidy deleted the fix-tests branch June 28, 2024 09:30
@swissspidy swissspidy modified the milestones: 2.1.6, 2.1.7 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants