update wp cli info

[thrijith]

to update #4599
change output format to table : #4604 (comment)

not sure if this is what you expected @gitlost, please provide your inputs for any changes.

[schlessera]

I wonder if people use the output from wp cli info for scripting purposes. If so, the above is a breaking change. I'll ask in #cli to get some (limited) feedback.

[gitlost]

Yes, apologies for the misleading comment @thrijith, although the output does look a lot better (though could do without the header). Please note this isn't a high priority at the moment so won't be reviewed immediately and may not make 1.5.0.

[thrijith]

ok @schlessera

[thrijith]

no problem @gitlost will remove the header.

[gitlost]

will remove the header.

@thrijith if instead you have time to investigate wp-cli/scaffold-command#109 and whether the output is compliant in other cases apart from the taxonomy one you fixed that would very much be appreciated!

[thrijith]

ok @gitlost will work on it then

[gitlost]

@thrijith am going to leave this PR out of 1.5.0 but will revisit shortly afterwards, ta!

[gitlost]

@thrijith re headerless table, at the moment need to workaround limitations of Utils\format_items(), WP_CLI\Formatter and cli\Table so maybe do

			$table = new \cli\Table;
			$table->setRows( $info );
			$table->setRenderer( new \cli\table\Ascii );
			$lines = array_slice( $table->getDisplayLines(), 2 ); // Remove header and border.
			foreach ( $lines as $line ) {
				\WP_CLI::line( $line );
			}

[gitlost]

Thanks for sticking with this @thrijith ! Although technically a BC break I think anyone who is parsing this is hopefully using the json format.

(One would have to agree with code climate though that this function could do with a bit of a refactor - the json and table paths should share and return the same data (with different keys) for instance. Also getting the shell should probably be put in a new Utils function. But these are for another day!)