review

Signed-off-by: Jade Turner <[email protected]>

.github/workflows/cmake.yml

@@ -5,7 +5,6 @@ on: [pull_request, push]
 concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
   cancel-in-progress: true
-
 env:
   SCCACHE_WEBDAV_ENDPOINT: "https://frcmaven.wpi.edu/artifactory/wpilib-generic-cache-cmake-local"
   SCCACHE_WEBDAV_KEY_PREFIX: "sccache"
@@ -39,15 +38,15 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y libopencv-dev libopencv4.5-java libprotobuf-dev protobuf-compiler ninja-build
 
       - name: Install dependencies (macOS)
-        run: brew install opencv protobuf@3 ninja
         if: runner.os == 'macOS'
+        run: brew install opencv protobuf@3 ninja
 
       - uses: ilammy/[email protected]
         if: runner.os == 'Windows'
 
       - name: Install CMake (Windows only)
-        uses: lukka/[email protected]
         if: runner.os == 'Windows'
+        uses: lukka/[email protected]
 
       - name: Run vcpkg (Windows only)
         if: runner.os == 'Windows'
@@ -74,12 +73,12 @@ jobs:
           SCCACHE_WEBDAV_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
 
       - name: test
+        if: runner.os != 'Windows'
         working-directory: build-cmake
         run: ctest --output-on-failure
-        if: runner.os != 'Windows'
 
       - name: test (windows)
+        if: runner.os == 'Windows'
         working-directory: build-cmake
         # UnitTest_test segfaults on exit occasionally
         run: ctest --output-on-failure -E 'UnitTest'
-        if: runner.os == 'Windows'