Upgrade to PMD 7.2.0 #6718
Merged
Upgrade to PMD 7.2.0 #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6597.
Some notes on suppressions:
SingularField was mostly suppressed in places where a Thread was created. I'm not sure whether or not the Thread object could actually be made completely local without unintended side effects from GC.
I suppressed ExceptionAsFlowControl and AvoidThrowingNewInstanceOfSameException because we do both pretty frequently. Not sure if we'd prefer to refactor there.
The spline classes explicitly create an array even though the method takes varargs. I assume it's a style thing, so I suppressed except for one spot in SplineHelper, since it was a 1D array of size 4.