Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unit UDL usage #6961

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

calcmogul
Copy link
Member

No description provided.

@calcmogul calcmogul requested review from a team as code owners August 14, 2024 05:28
@KangarooKoala
Copy link
Contributor

A few more spots that might be worth hitting in this PR as well:

wpilibc/src/main/native/cppcs/RobotBase.cpp:143:    return units::second_t{wpi::Now() * 1.0e-6};
wpilibc/src/main/native/include/frc/LEDPattern.h:111:   * particular LED strip units::meter_t LED_SPACING = units::meter_t{1 /60.0};
wpilibc/src/main/native/include/frc/LEDPattern.h:115:   *     rainbow.ScrollAtAbsoluteSpeed(units::inches_per_second_t{4},
wpilibc/src/main/native/include/frc/DMASample.h:64:    return units::second_t{static_cast<double>(GetTime()) * 1.0e-6};
wpilibc/src/main/native/cpp/PneumaticsControlModule.cpp:267:  return units::volt_t{0};
wpilibc/src/main/native/cpp/ADIS16470_IMU.cpp:821:  return units::degree_t{0.0};
wpilibc/src/main/native/cpp/counter/Tachometer.cpp:48:    return units::hertz_t{0.0};
wpilibc/src/main/native/cpp/counter/Tachometer.cpp:70:    return units::turns_per_second_t{0.0};
wpilibc/src/main/native/cpp/counter/Tachometer.cpp:74:    return units::turns_per_second_t{0.0};
wpilibc/src/main/native/cpp/counter/Tachometer.cpp:77:  return units::turns_per_second_t{rotationHz.value()};
wpimath/src/test/native/cpp/kinematics/MecanumDriveKinematicsTest.cpp:83:                       units::radians_per_second_t{2 * std::numbers::pi}};
wpimath/src/test/native/cpp/kinematics/SwerveDriveKinematicsTest.cpp:99:                       units::radians_per_second_t{2 * std::numbers::pi}};
wpimath/src/test/native/cpp/kinematics/SwerveDriveKinematicsTest.cpp:115:                       units::radians_per_second_t{2 * std::numbers::pi}};
wpimath/src/test/native/cpp/kinematics/SwerveDriveKinematicsTest.cpp:177:                       units::radians_per_second_t{2 * std::numbers::pi}};
wpimath/src/test/native/cpp/system/plant/proto/DCMotorProtoTest.cpp:16:const DCMotor kExpectedData = DCMotor{units::volt_t{1.91},
wpimath/src/test/native/cpp/system/plant/proto/DCMotorProtoTest.cpp:17:                                      units::newton_meter_t{19.1},
wpimath/src/test/native/cpp/system/plant/proto/DCMotorProtoTest.cpp:18:                                      units::ampere_t{1.74},
wpimath/src/test/native/cpp/system/plant/proto/DCMotorProtoTest.cpp:19:                                      units::ampere_t{2.29},
wpimath/src/test/native/cpp/system/plant/proto/DCMotorProtoTest.cpp:20:                                      units::radians_per_second_t{2.2},
wpimath/src/test/native/cpp/system/plant/struct/DCMotorStructTest.cpp:14:const DCMotor kExpectedData = DCMotor{units::volt_t{1.91},
wpimath/src/test/native/cpp/system/plant/struct/DCMotorStructTest.cpp:15:                                      units::newton_meter_t{19.1},
wpimath/src/test/native/cpp/system/plant/struct/DCMotorStructTest.cpp:16:                                      units::ampere_t{1.74},
wpimath/src/test/native/cpp/system/plant/struct/DCMotorStructTest.cpp:17:                                      units::ampere_t{2.29},
wpimath/src/test/native/cpp/system/plant/struct/DCMotorStructTest.cpp:18:                                      units::radians_per_second_t{2.2},

@calcmogul calcmogul force-pushed the clean-up-unit-udl-usage branch from 767712c to 517b6e9 Compare August 14, 2024 16:19
@PeterJohnson PeterJohnson merged commit 8e0d9ac into wpilibsuite:main Aug 14, 2024
35 checks passed
@calcmogul calcmogul deleted the clean-up-unit-udl-usage branch August 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants