Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpiutil, wpilib] Add FileLogger and log console output #6977

Merged
merged 6 commits into from
Sep 13, 2024
Merged

[wpiutil, wpilib] Add FileLogger and log console output #6977

merged 6 commits into from
Sep 13, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Aug 17, 2024

Fixes #6761.

@Gold856 Gold856 requested review from PeterJohnson and a team as code owners August 17, 2024 07:11
@Gold856 Gold856 marked this pull request as draft August 17, 2024 07:33
@Gold856
Copy link
Contributor Author

Gold856 commented Aug 17, 2024

/format

@Gold856 Gold856 marked this pull request as ready for review August 17, 2024 07:45
KangarooKoala
KangarooKoala reviewed Aug 17, 2024
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the /format run didn't seem to add the license to FileLogger.java.

wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
wpiutil/src/main/java/edu/wpi/first/util/FileLogger.java Outdated Show resolved Hide resolved
wpiutil/src/main/java/edu/wpi/first/util/WPIUtilJNI.java Outdated Show resolved Hide resolved
wpiutil/src/main/native/cpp/FileLogger.cpp Outdated Show resolved Hide resolved
@Gold856 Gold856 force-pushed the add-filelogger branch 4 times, most recently from 8b84d91 to 24fad79 Compare August 17, 2024 20:27
@rzblue
Copy link
Member

rzblue commented Aug 17, 2024

FRC_UserProgram.log won't exist in sim, the DataLogManager portion should only log that file when on the RIO.

rzblue
rzblue requested changes Aug 19, 2024
View reviewed changes
ntcoreffi/src/main/native/cpp/DataLogManager.cpp Outdated Show resolved Hide resolved
wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/cpp/FileLogger.cpp Outdated Show resolved Hide resolved
wpiutil/src/main/native/cpp/FileLogger.cpp Outdated Show resolved Hide resolved
rzblue
rzblue previously requested changes Aug 23, 2024
View reviewed changes
wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/include/wpi/FileLogger.h Outdated Show resolved Hide resolved
@Gold856 Gold856 force-pushed the add-filelogger branch 7 times, most recently from b1faa06 to b7c9f6d Compare August 24, 2024 23:09
@Gold856 Gold856 changed the title [wpiutil, wpilib] Add FileLogger and integrate with DLM [wpiutil, wpilib] Add FileLogger and log console output Aug 26, 2024
@Gold856 Gold856 force-pushed the add-filelogger branch 7 times, most recently from 6a0ab0e to 4736ec2 Compare August 28, 2024 07:17
@PeterJohnson PeterJohnson merged commit 3bbbf86 into wpilibsuite:main Sep 13, 2024
33 checks passed
@Gold856 Gold856 deleted the add-filelogger branch September 13, 2024 05:56
@rzblue rzblue mentioned this pull request Sep 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

@PeterJohnson PeterJohnson PeterJohnson approved these changes

@rzblue rzblue rzblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DataLog support for logging stdout/stderr
4 participants
@Gold856 @rzblue @PeterJohnson @KangarooKoala