[wpilibc] Fix missing symbols on Windows #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacey-sooty
force-pushed
the
windows-symbols
branch
4 times, most recently
from
c6a7acc to
bf26575
Compare
virtuald
reviewed
Sep 30, 2024
|
Does not resolve 7139, LedPattern is also broken. |
spacey-sooty
force-pushed
the
windows-symbols
branch
2 times, most recently
from
0cd072f to
c49cccb
Compare
PeterJohnson
requested changes
Sep 30, 2024
spacey-sooty
force-pushed
the
windows-symbols
branch
from
c49cccb to
772b0ca
Compare
PeterJohnson
approved these changes
Oct 1, 2024
Gold856
pushed a commit
to Gold856/allwpilib
that referenced
this pull request
Oct 10, 2024
Windows doesn't support direct static variable access across library boundaries in a mixed static/shared environment, so change to accessor functions.
Gold856
pushed a commit
to Gold856/allwpilib
that referenced
this pull request
Oct 10, 2024
Windows doesn't support direct static variable access across library boundaries in a mixed static/shared environment, so change to accessor functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7139