Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix cmake CI #7159

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[ci] Fix cmake CI #7159

merged 2 commits into from
Oct 4, 2024

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Oct 3, 2024

Apparently, a workflow file being invalid silently removes the check instead of reporting a failure.

Broken in #7153, the strategy key does not have access to the runner context. vcpkg also needs to be configured after checkout.

@rzblue rzblue requested a review from a team as a code owner October 3, 2024 22:17
@rzblue rzblue changed the title Fix cmake CI [ci] Fix cmake CI Oct 3, 2024
@PeterJohnson PeterJohnson merged commit bc6553c into wpilibsuite:main Oct 4, 2024
35 checks passed
Gold856 pushed a commit to Gold856/allwpilib that referenced this pull request Oct 10, 2024
Gold856 pushed a commit to Gold856/allwpilib that referenced this pull request Oct 10, 2024
@rzblue rzblue deleted the fix-cmake-10032024 branch October 16, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants