-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datalog] Move DataLogReaderThread from glass to new libdatalog #7641
base: 2027
Are you sure you want to change the base?
Conversation
92897bb
to
d429635
Compare
Try doing If that doesn't work, try |
f2ab2ec
to
d45aec8
Compare
Co-authored-by: Gold856 <[email protected]>
Co-authored-by: Gold856 <[email protected]>
894c428
to
9f02966
Compare
@@ -21,6 +21,7 @@ | |||
#define _WIN32_WINNT 0x0601 | |||
#define _WIN32_IE 0x0800 // MinGW at it again. FIXME: verify if still needed. | |||
#define WIN32_LEAN_AND_MEAN | |||
#define kInvalidFile reinterpret_cast<void*>(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a different PR for the fs.h/cpp change. Also, this file should be updated to use the new defined values in fs.h instead of replicating those changes here.
@@ -19,15 +19,15 @@ | |||
#include <vector> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think as we're moving these headers, we should put them in either wpi/log or wpi/datalog instead of the top level wpi. wpi/log would match the namespace, but datalog would be more consistent with struct and protobuf and the library name, etc. This would avoid the risk of conflicts with wpiutil since they're in two separate source directories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the namespace be changed to match as well?
Currently the major DataLog backend API (reading and writing) is split between wpiutil and glass. In the interest of allowing code that wants to use these APIs to not need to link to glass and declutter wpiutil, all of those APIs are moved to a new library named "libdatalog".