Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilibj] ADIS16470: Allow product ID of 16470 #7704

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[wpilibj] ADIS16470: Allow product ID of 16470 #7704

merged 1 commit into from
Jan 17, 2025
+2 −1

Conversation

PeterJohnson
Copy link
Member

C++ allows either 16982 or 16470, do the same for Java.

@PeterJohnson
[wpilibj] ADIS16470: Allow product ID of 16470
c34d812 
C++ allows either 16982 or 16470, do the same for Java.
@PeterJohnson PeterJohnson requested a review from a team as a code owner January 17, 2025 20:54
@github-actions github-actions bot added the component: wpilibj WPILib Java label Jan 17, 2025
@sciencewhiz
Copy link
Contributor

sciencewhiz commented Jan 17, 2025 •
edited
Loading

Would it make sense to report the product ID read in the error message, to make troubleshooting similar issues easier in the future?

@PeterJohnson
Copy link
Member Author

That's easy enough to add, although we should really do it across the board.

@PeterJohnson PeterJohnson merged commit 4caa16e into wpilibsuite:main Jan 17, 2025
47 checks passed
@PeterJohnson PeterJohnson deleted the fix-adis16470 branch January 17, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThadHouse ThadHouse ThadHouse approved these changes

Assignees
No one assigned
Labels
component: wpilibj WPILib Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterJohnson @sciencewhiz @ThadHouse