Develop #33
Merged
Develop #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A light-gray color variable has been added to _variables.scss and different sections of our code have been updated to use this new color variable instead of the hardcoded color value. The changes were made in _comments.scss and _posts-and-pages.scss to ensure uniformity in the color scheme across the Sass theme.
The PHP requirement has been reduced from 7.4 to 7.3 in the readme.txt file, accommodating more potential users. Furthermore, the version information of the theme was corrected from 1.0.4-beta1 to 1.0.4.
A new color variable, 'gray-base', has been added to the _variables.scss file in the wp-kit-elementor theme. This color value is now used for the 'text-color' variable, ensuring consistent color usage across the theme.
The readme.txt file of the wp-kit-elementor theme has been updated with a new gray-base color variable, and modifications to the light-gray color variable. Simultaneously, it reflects a downward revision of the PHP requirement from 7.4 to 7.3.
A new footer menu has been registered in the wp-kit-elementor theme. This change was made in the functions.php file and will allow for new navigation options at the bottom of the web pages.
The primary menu label in the wp-kit-elementor theme has been updated in the functions.php file. The label 'Primary Menu' was simplified to 'Primary'. This change does not affect functionality, but it improves menu readability.
This update includes adding a footer menu and renaming the primary menu label in the wp-kit-elementor theme. The theme's version number has been updated consistently across all relevant files.
The ID attribute and class name complexity in the site navigation tag were reduced for the 'wp-kit-elementor' theme. This simplifies the HTML structure and improves readability without any negative impact on functionality.
Footer code has been moved to a separate 'template-parts/footer' file to improve code organization in the 'wp-kit-elementor' theme. The footer now consists of footer navigation and credit section, enhancing the structural clarity of the theme's codebase.
Renamed navigation-related classes and improved styling in the wp-kit-elementor theme's SASS code. The 'primary-navigation' classes have been renamed to 'site-navigation', and redundant margin-bottom styling for list items have been removed, setting a more uniform and readable code standard.
Enhanced footer presentation by adding display flex, flex-wrap, and justify-content properties in the site-footer class in the wp-kit-elementor theme's SASS code. Additionally, padding was moved from the 'footer-copyright' class to the 'site-footer' class for better visual appeal.
In this update, the footer code for the wp-kit-elementor theme was moved to a new, separate file for better organization. Along with this, the footer's styling was updated for improved visual design. Other changes include the simplification of the site navigation tag and a refactor of the navigation styling.
The changes refer to the CSS properties of the site-title selector in the wp-kit-elementor theme. The 'font-size' property was adjusted to 2.5rem for improved size prominence, while the 'font-weight' was set to 500 to maintain a balanced text weight. This enhances the readability and overall appearance of the site title within the theme's header.
Cleansed 'header.php' file in 'wp-kit-elementor' theme by deduction of superfluous line breaks. Aimed at enhancing the code's readability and maintaining PHP coding standard conventions.
The commit has introduced the width and height attributes to the image tag in the readme markdown file. The specific dimensions provided would ensure that the image is presented in a more structured and visually consistent manner.
The commit simplifies the image source URL in the README.md file. The URL parameters related to image width and stripping metadata have been removed, largely for clarity and simplicity. Image width and height are still controlled by the HTML attributes within the Markdown.
The image tag in README.md file of wp-kit-elementor theme was updated. The dimensions attributes of the image were removed as they are already controlled by the HTML attributes within the Markdown, providing a cleaner and simpler image tag.
The functions.php file in wp-kit-elementor theme was updated to remove the feature of custom background support. This helps to simplify the theme and prevents potential conflicting settings with default color.
The theme and author name has been updated in style.scss file. 'WP Kit Elementor' has been changed to 'WpKit Elementor' and 'WP Kit' to 'WpKit'. These changes ensure consistency in branding across the project.
This commit does two main things - firstly, the file paths in the webpack.config.js have been updated to reflect the renaming of 'kit-frontend', 'kit-editor' and 'kit-admin' to 'wpkit-frontend', 'wpkit-editor' and 'wpkit-admin' respectively. Secondly, unnecessary comments in style-editor.scss have been removed for cleaner code readability.
In the 'functions.php' file of wp-kit-elementor theme, function names have been renamed with 'wp_kit_elementor' prefixes to enhance readability and avoid possible naming conflicts. Concurrently, the theme version has been updated to '1.0.5', and style and script file names have also been made more consistent. The overall aim of these collective changes is to streamline codebase management and improve theme function handling.
The 'Stable tag' property has been removed from the theme's SCSS file as it was inconsistent with the stated theme version and hence deemed unnecessary. This change was made during a broader clean-up of the codebase, aimed to help streamline code management and improve theme functionality.
In the webpack configuration file, the 'wpkit-admin' entry has been deleted. This change reflects that we're no longer bundling scripts specific to the 'wpkit-admin' area in our project.
The "name" and "slug" properties in the package.json file for the wp-kit-elementor theme have been modified. The "-theme" suffix has been removed in both properties to make them more consistent with the project's naming convention.
…nto develop # Conflicts: # assets/sass/style.scss # functions.php # package.json # readme.txt
The commit addresses the changes in the version details of the wp-kit-elementor theme within the readme.txt file. It moves from version 1.0.5 to 1.0.6, reflecting the latest modifications and enhancements made to the theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.