Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes after removal of NullBooleanField from DRF #85

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

tomaszn
Copy link
Contributor

@tomaszn tomaszn commented Aug 1, 2023

This PR:

  • makes wq.db v1.3.x compatible with Django 4.1 via DRF upgrade to 3.14.x
  • breaks the EAV feature (and so its tests are failing, possibly because of this change)

I've never used EAV, and don't know how to fix it.
So I'm OK with seeing a new maintenance branch (wq.db 1.4.x) without this feature, but compatible with the latest Django series ;-)

@sheppard
Copy link
Member

sheppard commented Aug 25, 2023

Hi, @tomaszn. I think we can keep this as a 1.3 release, but just make a note that EAV mustache context helpers do not work in Django 4.1. Could you add a @unittest.skipIf(DJANGO_4_1) to the failing tests? Then I think this should be good to merge and release as 1.3.2.

@tomaszn
Copy link
Contributor Author

tomaszn commented Aug 28, 2023

@sheppard Please take a look if that is what you meant. Thanks

@sheppard sheppard merged commit 6469b6d into wq:1.3 Nov 8, 2023
@sheppard
Copy link
Member

sheppard commented Nov 8, 2023

I finally released this as 1.3.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants