Fix communication between Batch instances and ECS tasks

[dmannarino]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
• Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
• Check the commit's or even all commits' message styles matches our requested structure.
• Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

• Batch instances time-out trying to phone home their success or failure
• Also, per the docs, specifying inline rules in a SG and then externally defined rules can result in inconsistent behavior during apply

Issue Number: GTC-2860

What is the new behavior?

• Batch instances report home okay
• All rules are externally define, removing inconsistency

Does this introduce a breaking change?

• Yes
• No

Other information

Data API PR (to attach the security group to the compute environments) to follow

[danscales]

Seems reasonable, but I'll let Solomon provide the full "approve".

[danscales]

Is listener_port being used for two meanings, what the load balancer should listen on and what the ECS tasks should listen on for batch jobs? If so, can you update the comment on var.listener_port in variables.tf? Or create a separate variable var.ecs_tasks_port with the same value 80?

[dmannarino]

Ahh, I see. Yeah, the code and comments have diverged quite a bit. Will fix, thanks!