Bugfix/TCL_true_color

[manukala6]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
• Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
• Check the commit's or even all commits' message styles matches our requested structure.
• Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: GTC-2916

What is the new behavior?

• Switches to using float values to calculate RGBA values for TCL

Does this introduce a breaking change?

• Yes
• No

Other information

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (4fa29c0) to head (7938c11).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #161      +/-   ##
==========================================
+ Coverage   79.73%   79.76%   +0.03%     
==========================================
  Files          57       57              
  Lines        1895     1898       +3     
==========================================
+ Hits         1511     1514       +3     
  Misses        384      384              

Flag	Coverage Δ
unittests	79.76% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danscales]

Do you want to clip red to 255 as well? If not, can you put in a comment on why you don't need to clip it. (For instance, maybe intensity.shape is only a value between 0 and 1, so you know red is already between 0 and 228?)

[danscales]

Any chance you can describe in a comment the type of intensity.shape, and what the possible range of its values are? That would also make it clearer why float32 is the right choice for maintaining accuracy (and for instance, why you don't need to use float64).