Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeguard join "method" kwarg #1150

Merged
merged 6 commits into from
Jan 29, 2024
Merged

safeguard join "method" kwarg #1150

merged 6 commits into from
Jan 29, 2024

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Jan 26, 2024 •
edited
Loading

Changes

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ddkohler ddkohler changed the title implement value check safeguard join "method" kwarg Jan 26, 2024
@ddkohler ddkohler marked this pull request as ready for review January 27, 2024 05:04
kameyer226
kameyer226 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@kameyer226 kameyer226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that sum didn't work out...

@kameyer226 kameyer226 merged commit a7c0461 into master Jan 29, 2024
17 checks passed
@kameyer226 kameyer226 deleted the issue-1118 branch January 29, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kameyer226 kameyer226 kameyer226 approved these changes

@untzag untzag Awaiting requested review from untzag untzag is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@ddkohler @kameyer226