Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setpoint implementation #48

Merged
merged 10 commits into from
Jun 2, 2019
Merged

Initial setpoint implementation #48

merged 10 commits into from
Jun 2, 2019

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Mar 20, 2019

Supercedes #41

Requires https://github.com/wright-group/WrightTools/pulls/883 and therefore will fail automated tests.

There are certainly some rough edges/tweaking of default parameters to be done.

Differences from wt2:

  • splines in differential axis space, not absolute
  • uses moments ranther than gaussian fitting
  • fewer pre-cleaning operations performed on test
  • pre-cleaning operations external to workup function, thus finding the "setpoint measured channel" has to be done prior to this call.
  • relatively memory safe (though not perfect in that respect)
  • units behavior may be different, have not tested extensively, fitting is done in wn space for now (see Handling of unit systems #38)
  • Representation generated uses detuning in a signed color map, rather than plotting detuning vs absolute motor as wt2 did. This is more in line with how the intensity plot is generated.

@ksunden
Copy link
Member Author

ksunden commented Mar 20, 2019

Wire 2019-03-20 at 16 45 34

Example of the auto-generated plot, as well as comparison to wt2 differentials

@ksunden
Copy link
Member Author

ksunden commented Mar 20, 2019

May wish to flip the cmap for energy data, such that "blue shift" and "red shift" are consistent, currently it follows the convention of "red positive", "blue negative" for a) simplicity, b) consistency with that colormap's usage in general, though red/blue shift is a good argument

@untzag untzag merged commit 56a85f9 into master Jun 2, 2019
@untzag untzag deleted the setpoint branch June 2, 2019 20:47
@untzag untzag added this to the 0.1.0 milestone Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants