-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship 2024 website & ticket sales #2065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid.
@@ -4,11 +4,106 @@ | |||
Lightning Talks | |||
=============== | |||
|
|||
{% include "conf/events/lightning-talks.rst" %} | |||
A lightning talk is a short talk, up to 5 minutes, where you share an idea, concept, or a bit of information you find interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we moving this back into the conf dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because trying to manage edits with a bunch of includes is really difficult with folks who don't know Git/Sphinx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but the includes are there for a reason. Especially if we're doing both ways, and across three conferences. I'd rather not revert here, how about just documenting where things are inline? But if we are are we doing it for all 2024 confs? And then how are we updating next year?
CC @mxsasha for comment here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericholscher happy to decouple this from merging the PR if you want to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I think we can look at backporting changes once we've done our edits, but it's a bit harder because we're mixing "evergreen" and conference-specific content in ordering, because it reads nicer :/
This includes a bunch of copy edits from Katie.
📚 Documentation preview 📚: https://writethedocs-www--2065.org.readthedocs.build/