-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtp: Add Armenia WTD group info #2147
base: main
Are you sure you want to change the base?
Conversation
This won't work as is, Sphinx is looking for a non existant |
Any suggestions? I'd love a secondary solution because some of the groups are also creating location specific Write the Docs LinkedIn pages that I think it would be good to include. |
Yeah, I'll poke at the code, won't happen overnight but shouldn't be super tricky |
Hey @rosewms this is good to go! Merge at will, and lemme know if oyu have any questions? |
This is related to #2242 and attempts to remove the need for an actual meetup.com URL as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to add a schema for validation!
docs/_data/schema-meetups.yaml
Outdated
city: str(required=False) | ||
website: str(required=False) | ||
twitter: str(required=False) | ||
meetup: str(required=False) # I can't figure out how to validate must contain either meetup or meetup_alt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think there is a way to do this in the schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it feels like there should be.
We could refactor to something like:
source:
# one of
meetupcom: example
linkedin: example
other: example
and then I believe we could something along these lines https://github.com/23andMe/Yamale?tab=readme-ov-file#lists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've gone a ahead and done that, and it seems to work, thought it still breaks my brain a little.
Co-authored-by: Sasha Romijn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly my PR now! But I'm happy with it :-p
link: str(required=False, none=False) | ||
|
||
source_meetup: | ||
meetup: str(required=True, none=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could call this and the other one "url"? So that you only flip whether url is under source_meetup or source_other. Feels cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I actually went the other way to
source:
meetup:
and
source:
other:
but I'm falling into the trap of half assing things:
Adding the Armenia WTD group info to the Meetups page.
Note, might update the page title to "Meetups and communities" to better reflect the new platforms available.
Merge 2118 before this PR.
📚 Documentation preview 📚: https://writethedocs-www--2147.org.readthedocs.build/