-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to locally run HTMLProofer #2285
base: main
Are you sure you want to change the base?
Add option to locally run HTMLProofer #2285
Conversation
Add Ruby installation and html-proofer gem to devcontainer Add Ruby installation and html-proofer gem to devcontainer
I'd be open to moving the htmlproofer link check out into external config or script to make it easier to run both locally and in CI. The issue I ran into when running locally was that there are a lot of links like "/site-map/" which fail locally, and we'd have to figure out a way to address those. Or run it against a locally running server. 🤷♂️ Also a load of options which are valid in CI aren't locally (also probably a different version thing). This part of the tool chain is really not a joy. |
I saw this also locally. Maybe this is something we can fix later if the sphinx-ubuntu passes? My secondary goal is to keep the |
- name: Install Ruby dependencies | ||
run: bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably :p - sorry for the mess
- name: Install Ruby dependencies | |
run: bundle install | |
- name: Install Ruby dependencies | |
run: bundle install |
What
This PR adds the option to locally run HTMLProofer. With the Python upgrade #2271 I ran into a problem with the html generation. This makes it easier to run the check without waiting for the Github actions to finish.
How to test
>Dev Containers: Reopen in Container
cd docs/
to navigate to the docs foldermake html
to generate the html insidedocs/_build
cd ../
to navigate back to the root folderhtmlproofer --ignore-files "/404/,/2013/,/2014/,/2015/,/2016/,/2017/,/search\/index.html/" --allow-hash-href=true --enforce-https=false --ignore-missing-alt=true --disable-external=true docs/_build/html
TODO
ruby/setup-ruby
action.📚 Documentation preview 📚: https://writethedocs-www--2285.org.readthedocs.build/