SDK for QR Code Based Authentication Project. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashensw
reviewed
Apr 25, 2022
| authResponse: authResponse | ||
| }; | ||
|
|
||
| const authUrl = "https://192.168.1.3:9443/qr-auth/authenticate"; |
There was a problem hiding this comment.
The server URL should be configurable.
thivi
approved these changes
Apr 28, 2022
Comment on lines
39
to
46
| if (sessionDataKey) { | ||
| authRequest = { | ||
| sessionDataKey: sessionDataKey, | ||
| tenantDomain: tenantDomain, | ||
| }; | ||
| } else { | ||
| throw new Error("One or more required parameters (tenantDomain, sessionDataKey) was not found."); | ||
| } |
|
|
||
| return result.then((res) => { | ||
| let result; | ||
| if (res.status === 202 && response == "SUCCESSFUL") { |
There was a problem hiding this comment.
Better if string literals like SUCCESSFUL can be moved to enums.
Comment on lines
37
to
42
| date: | ||
| current.getDate() + | ||
| "-" + | ||
| current.getMonth() + | ||
| "-" + | ||
| current.getFullYear(), |
There was a problem hiding this comment.
It's better to use the toLocaleDateString method to do this.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString
Comment on lines
43
to
51
| time: | ||
| (current.getHours() < 12 | ||
| ? current.getHours() | ||
| : current.getHours() - 12) + | ||
| ":" + | ||
| current.getMinutes() + | ||
| (current.getHours() < 12) | ||
| ? " a.m." | ||
| : " p.m." |
There was a problem hiding this comment.
It's better to use the toLocaleDateString method to do this.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString
Or you can try toISOString.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString
| return response; | ||
| }) | ||
| .catch((err: any) => { | ||
| console.log(`error: ${err.status}`); |
| body: body | ||
| }) | ||
| .then((response: any) => { | ||
|
|
thivi
approved these changes
Apr 28, 2022
Co-authored-by: Theviyanthan Krishnamohan <[email protected]>
Co-authored-by: Theviyanthan Krishnamohan <[email protected]>
Co-authored-by: Theviyanthan Krishnamohan <[email protected]>
Co-authored-by: Theviyanthan Krishnamohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the SDK for the QR Code Based Authentication project.
Related Issue : wso2/product-is#12833