Implement workflow approvalService #1

IsharaSilva · 2022-06-07T14:54:10Z

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information
Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

chamathns · 2022-06-09T04:42:29Z

components/org.wso2.carbon.identity.workflow.engine/pom.xml

+        <dependency>
+            <groupId>org.wso2.carbon.identity.framework</groupId>
+            <artifactId>org.wso2.carbon.identity.configuration.mgt.core</artifactId>
+            <version>5.18.187</version>


Add versions as properties

Addressed with this commit 42e8139

chamathns · 2022-06-09T04:42:40Z

components/org.wso2.carbon.identity.workflow.engine/pom.xml

+            <artifactId>org.apache.felix.scr.ds-annotations</artifactId>
+            <version>${apache.felix.scr.ds.annotations.version}</version>
+        </dependency>
+


redundant blank line

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:43:00Z

components/org.wso2.carbon.identity.workflow.engine/pom.xml

+
+    </dependencies>
+
+


redundant blank line. let's fix other places as well

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:43:21Z

components/org.wso2.carbon.identity.workflow.engine/pom.xml

+    </properties>
+
+
+</project>


Add new line

Addressed with this commit 1efe729

chamathns · 2022-06-09T04:43:42Z

...w.engine/src/main/java/org.wso2.carbon.identity.workflow.engine/DefaultApprovalWorkflow.java

+
+import java.util.List;
+
+public class DefaultApprovalWorkflow extends AbstractWorkflow {


Add class comments. Let's fix other places as well

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:44:32Z

...w.engine/src/main/java/org.wso2.carbon.identity.workflow.engine/DefaultApprovalWorkflow.java

+    public DefaultApprovalWorkflow(Class<? extends WorkFlowExecutor> workFlowExecutorClass, String metaDataXML)
+            throws WorkflowRuntimeException {
+
+        super(null, workFlowExecutorClass, metaDataXML);


Why are we passing a null here?

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:45:06Z

...w.engine/src/main/java/org.wso2.carbon.identity.workflow.engine/DefaultApprovalWorkflow.java

+    @Override
+    protected InputData getInputData(ParameterMetaData parameterMetaData) {
+
+        return null;


Let's return an instance of the InputData class here

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:45:45Z

...c/main/java/org.wso2.carbon.identity.workflow.engine/DefaultWorkflowEventRequestService.java

+
+public class DefaultWorkflowEventRequestService implements DefaultWorkflowEventRequest {
+
+    public void addApproversOfRequests(WorkflowRequest request, List<Parameter> parameterList) {


Add method comments to public methods

Addressed with this commit 0f8bc6d

chamathns · 2022-06-09T04:47:07Z

...c/main/java/org.wso2.carbon.identity.workflow.engine/DefaultWorkflowEventRequestService.java

+                }
+            }
+        }
+        workflowEventRequestDAO.addApproversOfRequest(taskId, eventId, workflowId, approverType, approverName);


We need to add approvers if there are multiple approvers for a single step. Include this inside the for loop

Addresses with this commit 0f8bc6d

chamathns · 2022-06-09T04:49:19Z

...c/main/java/org.wso2.carbon.identity.workflow.engine/DefaultWorkflowEventRequestService.java

+                        String[] approvers = approver.split(",");
+                        if (approvers != null) {
+                            List<String> approverList = Collections.singletonList(approver);
+                            String stepValue = WorkflowEngineConstants.ParameterName.USER_AND_ROLE_STEP + "-step-" +


Let's use constants for pattern matching like "-step-"

Addressed with this commit 0f8bc6d

IsharaSilva · 2022-07-29T10:18:57Z

components/org.wso2.carbon.identity.workflow.engine/pom.xml

+                 <plugin>
+                     <groupId>org.apache.felix</groupId>
+                     <artifactId>maven-bundle-plugin</artifactId>
+                     <version>3.2.0</version>


add property

Addresses this issue from 032e778 of 2nd PR.

IsharaSilva · 2022-08-01T19:23:43Z

...gine/src/main/java/org/wso2/carbon/identity/workflow/engine/DefaultWorkflowEventRequest.java

+     * @param request       workflow request object.
+     * @param parameterList parameterList.
+     */
+    void addApproversOfRequests(WorkflowRequest request, List<Parameter> parameterList);


rename methods.
Fix other places as well

addressed these type of issues from 032e778 of 2nd PR.

IsharaSilva · 2022-08-01T19:26:29Z

...w.engine/src/main/java/org/wso2/carbon/identity/workflow/engine/DefaultApprovalWorkflow.java

+        InputData inputData = null;
+        if (parameterMetaData != null && parameterMetaData.getName() != null) {
+            String parameterName = parameterMetaData.getName();
+            if (BPS_PROFILE.equals(parameterName)) {


remove BPS profile

addressed with commit 032e778 of 2nd PR.

IsharaSilva · 2022-08-01T19:34:06Z

pom.xml

+            <plugin>
+                <groupId>org.apache.felix</groupId>
+                <artifactId>maven-bundle-plugin</artifactId>
+                <version>3.2.0</version>


add property

addressed with this commit 5d282d6 of 2nd PR.

IsharaSilva · 2022-08-01T19:35:06Z

...n/java/org/wso2/carbon/identity/workflow/engine/internal/WorkflowEngineServiceComponent.java

+                "    <met:WorkflowImplDescription>Approval Workflow</met:WorkflowImplDescription>\n" +
+                "    <met:TemplateId>MultiStepApprovalTemplate</met:TemplateId>\n" +
+                "    <met:ParametersMetaData>\n" +
+                "        <met:ParameterMetaData Name=\"BPSProfile\" InputType=\"Select\" isRequired=\"true\" isInputDataRequired=\"true\">\n" +


remove BPS Profile

addressed with this commit f476a48 of 2nd PR.

Implement workflow approvalService

643a396

IsharaSilva force-pushed the default-wf-engine branch from 3529d94 to 643a396 Compare June 8, 2022 05:42

chamathns suggested changes Jun 9, 2022

View reviewed changes

IsharaSilva added 7 commits June 9, 2022 22:27

Implement workflow approvalService

0f8bc6d

Implement workflow approvalService

1efe729

Implement workflow approvalService

42e8139

Implement workflow approvalService

80ed261

Implement workflow approvalService

5589a4c

Update pom.xml

4a884a4

Update WorkflowEngineServiceComponent.java

93cce6d

IsharaSilva commented Aug 1, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement workflow approvalService #1

Implement workflow approvalService #1

IsharaSilva commented Jun 7, 2022

chamathns Jun 9, 2022

IsharaSilva Jun 21, 2022

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

chamathns Jun 9, 2022

IsharaSilva Jun 10, 2022

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022

chamathns Jun 9, 2022

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jul 29, 2022

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022

IsharaSilva Aug 1, 2022 •

edited

Loading


		import java.util.List;

		public class DefaultApprovalWorkflow extends AbstractWorkflow {


		public class DefaultWorkflowEventRequestService implements DefaultWorkflowEventRequest {

		public void addApproversOfRequests(WorkflowRequest request, List<Parameter> parameterList) {

		</properties>


		</project>

Implement workflow approvalService #1

Are you sure you want to change the base?

Implement workflow approvalService #1

Conversation

IsharaSilva commented Jun 7, 2022

Purpose

Goals

Approach

User stories

Release note

Documentation

Training

Certification

Marketing

Automation tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

Learning

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsharaSilva Aug 1, 2022 • edited Loading

Choose a reason for hiding this comment

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Jun 9, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022 •

edited

Loading

IsharaSilva Aug 1, 2022 •

edited

Loading