Ensure security config dialog is properly updated with props changes #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piumal1999
requested review from
lasanthaS,
Krishanx92,
tharikaGitHub and
piyumaldk
as code owners
|
AnuGayan
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Purpose of the PR is to fix wso2/api-manager#3661
Issue
When the user clicks the security configuration button while the endpoint text box is focused, both editEndpoint and toggleEndpointSecurityConfig are triggered simultaneously. This causes the securityInfo to become undefined after the security config dialog box is opened.
Fix
Added a useEffect hook to ensures that securityInfo is reinitialized with the default values if the props change while the dialog box is open