Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to switch data source for Admin Banner & Remote Logging Configs #6475

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

darshanasbg
Copy link
Contributor

Proposed changes in this pull request

$subject.

When should this PR be merged

Immediate.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13234527406

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (52a9a31) to head (7dcc4ab).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
.../mgt/internal/SystemConfigMgtServiceComponent.java 0.00% 17 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6475      +/-   ##
============================================
+ Coverage     46.87%   47.03%   +0.15%     
+ Complexity    15282    15219      -63     
============================================
  Files          1748     1748              
  Lines        106216   105562     -654     
  Branches      19495    19415      -80     
============================================
- Hits          49787    49646     -141     
+ Misses        49375    48879     -496     
+ Partials       7054     7037      -17     
Flag Coverage Δ
unit 30.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg marked this pull request as ready for review February 10, 2025 06:50
@UdeshAthukorala UdeshAthukorala merged commit 0a90f6a into wso2:master Feb 10, 2025
4 of 5 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13234527406
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13234527406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants