Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate system authenticators names at registering. #6489

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

With this PR, verify that the registering system-defined authenticator name starts with the custom- prefix, which is reserved for user-defined authenticators, if so ignore that authenticator and add warn log.

@Thisara-Welmilla Thisara-Welmilla force-pushed the validate-system-authenticator-names branch from 90ff1ae to d07a3b6 Compare February 13, 2025 11:50
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13307683398

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.14%. Comparing base (64a8b25) to head (efd323a).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
.../framework/internal/FrameworkServiceComponent.java 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6489      +/-   ##
============================================
- Coverage     47.15%   47.14%   -0.02%     
- Complexity    15278    15305      +27     
============================================
  Files          1747     1747              
  Lines        105380   105561     +181     
  Branches      19488    19544      +56     
============================================
+ Hits          49694    49763      +69     
- Misses        48631    48738     +107     
- Partials       7055     7060       +5     
Flag Coverage Δ
unit 30.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13307683398
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the validate-system-authenticator-names branch from d07a3b6 to bc178fe Compare February 14, 2025 01:46
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13320800967

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13320800967
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the validate-system-authenticator-names branch 2 times, most recently from f439dd8 to bb4a233 Compare February 14, 2025 02:24
@Thisara-Welmilla Thisara-Welmilla force-pushed the validate-system-authenticator-names branch from bb4a233 to efd323a Compare February 14, 2025 02:27
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13321248203

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13321248203
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13321248203

@Thisara-Welmilla Thisara-Welmilla merged commit f413689 into wso2:master Feb 14, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants