-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate system authenticators names at registering. #6489
Validate system authenticators names at registering. #6489
Conversation
90ff1ae
to
d07a3b6
Compare
PR builder started |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6489 +/- ##
============================================
- Coverage 47.15% 47.14% -0.02%
- Complexity 15278 15305 +27
============================================
Files 1747 1747
Lines 105380 105561 +181
Branches 19488 19544 +56
============================================
+ Hits 49694 49763 +69
- Misses 48631 48738 +107
- Partials 7055 7060 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
d07a3b6
to
bc178fe
Compare
PR builder started |
PR builder completed |
...carbon/identity/application/authentication/framework/internal/FrameworkServiceComponent.java
Outdated
Show resolved
Hide resolved
f439dd8
to
bb4a233
Compare
bb4a233
to
efd323a
Compare
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13321248203
Issue:
With this PR, verify that the registering system-defined authenticator name starts with the
custom-
prefix, which is reserved for user-defined authenticators, if so ignore that authenticator and add warn log.