-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check claim uniqueness without duplicate claim check #6492
base: master
Are you sure you want to change the base?
Check claim uniqueness without duplicate claim check #6492
Conversation
|
PR builder started |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6492 +/- ##
============================================
+ Coverage 46.86% 47.19% +0.33%
- Complexity 15252 15292 +40
============================================
Files 1747 1747
Lines 105558 105400 -158
Branches 19565 19511 -54
============================================
+ Hits 49467 49742 +275
+ Misses 49076 48602 -474
- Partials 7015 7056 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13323378339
Please add unit tests |
Purpose
Password can't be equal to login attributes
policy check correctly by only validating if the password is equal to a unique claim. It won't check if the unique claim is duplicated with other usercheckClaimUniqueness
method to check if the password is equal to a login attribute. The problem here is that thecheckClaimUniqueness
is doing additional validation where it checks if the login attributes have been duplicated in the same userstore. So if two users share the same login attribute values (ex: same emails), when the password is getting updated, it will first checkIn this PR, we have introduced a new method that only does the first check and ignores the second check for admin-initiated password reset scenarios
Related Issue(s)