-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error at cloning authentication context. #6498
Fix error at cloning authentication context. #6498
Conversation
2b4393e
to
9d1b8ef
Compare
...tity/application/authentication/framework/internal/core/ApplicationAuthenticatorManager.java
Show resolved
Hide resolved
...tity/application/authentication/framework/internal/core/ApplicationAuthenticatorManager.java
Show resolved
Hide resolved
...tity/application/authentication/framework/internal/core/ApplicationAuthenticatorManager.java
Outdated
Show resolved
Hide resolved
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
...tity/application/authentication/framework/internal/core/ApplicationAuthenticatorManager.java
Show resolved
Hide resolved
9d1b8ef
to
152aa13
Compare
* Returns extended IDP with resource ID. | ||
* Note: The UserDefinedFederatedAuthenticatorConfig object in the IdentityProvider is not serializable using | ||
* org.apache.commons.lang3.SerializationUtils, which is used in the authentication framework to clone the | ||
* authentication context. Hence, use getSerializableIdPByResourceId(String, String) in FrameworkUtils, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add @link annotation and this is not in FrameworkUtils right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot use link as we need to import framework component here.
Updated the commnet FrameworkUtils
-> ApplicationAuthenticatorManager
152aa13
to
bae7081
Compare
|
PR builder started |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (37.50%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6498 +/- ##
============================================
- Coverage 47.15% 46.96% -0.19%
- Complexity 15278 15309 +31
============================================
Files 1747 1747
Lines 105380 106002 +622
Branches 19488 19646 +158
============================================
+ Hits 49694 49786 +92
- Misses 48631 49143 +512
- Partials 7055 7073 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13332521995
Issue:
Follwoing changes are added with this PR:
IdentityProviderManager.getInstance()
->FrameworkServiceDataHolder.getInstance().getIdentityProviderManager()