Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all string occurrences from 'custom-authentication' to 'custom-authenticator' for consistency #6500

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

Shenali-SJ
Copy link
Contributor

Purpose

This PR refactors all the string occurrences such as variables, functions. files etc. should be refactored from authentication to authenticator with regards to custom authenticator feature introduction in the identity apps code base.

Related Issue

@Shenali-SJ Shenali-SJ marked this pull request as ready for review February 14, 2025 18:31
@Shenali-SJ
Copy link
Contributor Author

This is required since initially the authenticator was named as "Custom Authentication". After careful consideration the team agreed to refactor the name to "Custom Authenticator" in order to preserve the consistency of the connections page.

cc: @malithie @jeradrutnam

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.03%. Comparing base (bff0c52) to head (1c7d1e3).
Report is 52 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6500      +/-   ##
============================================
- Coverage     47.20%   47.03%   -0.18%     
- Complexity    15299    15309      +10     
============================================
  Files          1747     1747              
  Lines        105397   105858     +461     
  Branches      19518    19628     +110     
============================================
+ Hits          49757    49792      +35     
- Misses        48580    48988     +408     
- Partials       7060     7078      +18     
Flag Coverage Δ
unit 30.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@malithie malithie merged commit 82b686b into wso2:master Feb 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants