-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle session retrieval issue for sub org users #6506
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6506 +/- ##
============================================
- Coverage 45.96% 45.94% -0.02%
- Complexity 14867 14870 +3
============================================
Files 1737 1737
Lines 107351 107400 +49
Branches 19876 19890 +14
============================================
+ Hits 49343 49346 +3
- Misses 50977 51026 +49
+ Partials 7031 7028 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ity/application/authentication/framework/internal/impl/UserSessionManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
PR builder completed |
Proposed changes in this pull request
This PR is introduced to handle session retrieval issues for sub org users. Currently only the session created in sub org is shown when getting the session list of sub org list. Ideally session created in primary org should be listed and sub org session should not be listed.
When implementing the fix, following cases are considered.
Before the fix [1], the behaviour was,
After the fix [1] which is done to address the case 4,
With this fix, we handled the above four cases to have expected behaviour.
[1] - #5693
Related Issue - wso2/product-is#22310